Code Reviews - PHP Unconference Europe 2013

ENTER

Code Peer Reviews

Leave your ego at the door

05.05.2013 Frank Sons – PHP Unconference Europe 2013

Who am I?

Software Quality Engineer

Doing PHP/Java/etc. for ~15 years

PHP Usergroup Hamburg

Still learning!

05.05.2013 2Frank Sons – PHP Unconference Europe 2013

So, what‘s this about?

Introducing Reviews

Collective Coder Ownership

The right review for the right job

Beware the dragons!


A short introduction to reviews

Forget about the code for the moment…

05.05.2013 Frank Sons – PHP Unconference Europe 2013 4

What‘s the idea?


Peer review methods are employed to maintain standards, improve

performance and provide credibility.

Wikipedia: Peer review

Reviews aren‘t limited to code…


Back to code reviews…

IBM: Inspection introduced 1970s


Google: 20% rule used for reviews

„That‘s not my code!“

Collective code ownership is a mindset


What about the ego?


“Everyone has the right and freedom to totally suck in private.”

Jeff Atwood - @codinghorror

Forget about your ego!


“Attempt to be awesome in public and embrace the suck!”

Jeff Atwood - @codinghorror

Reviews are knowledge sharing!


Share within your team…

Product knowledge

Technical knowledge

Coding Standards

Transparency


Finding the right review method

What do you want to do today?


Ad hoc

Just ask someone

Takes only a few minutes

Happens everywhere

Little impact beyond problem

Completely informal


Peer deskcheck / pass around

Asking someone for input

Can be done asynchronous

Author is not present

Good for mentoring and coaching

Very informal


Pair programming

Agile approach

Driver and Navigator

Rapid Iterations

Cultural change needed

Informal review


Walkthrough

Author explains code

Code reading

Ideal to present and educate

Risk of overlooking critical code

Informal, no defined process


Inspection

Most formal approach

Industry standard

Specific roles and trained inspectors

Checklist

Moderated review


„Inspection Walkthrough“

Reader doesn‘t know code

Experienced dev: „eagle eye“ view

Author explains / answers questions

Specific code section

No Leads involved


Beware the dragons!

It can be tricky…


Egoless!


My ego ist not tied to my “perfect” or “imperfect” work product

Avoid the dragons

No fingerpointing

Leave the egos at the door

Resistance to change

Lack of knowledge

Cultural issues


Keep this in mind

Three to seven participants

Keep it at two hours max

Involve Managers in planning

Find problems not solutions

Review coverage vs. Project size


You will see the benefits

Code will be understandable

Knowledge is spread

Improves communication

Light house effects


JUST DO IT!


This helps…


Enjoy your reviews!

Reviews can help your team

Reviews are all about the mindset

Don‘t fear the dragons


Liked it? Contact me!

[email protected]

Twitter: @FrankS

slideshare.net/frank_sons

Ask for a card ;-)


Thanks!

05.05.2013 29

Code Reviews - PHP Unconference Europe 2013

Technology

Transcript of Code Reviews - PHP Unconference Europe 2013